cardano-cli Plutus Datum JSON format support #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rooooooooob
commented
Feb 2, 2022
rooooooooob
commented
Feb 2, 2022
rust/src/utils.rs
Outdated
| @@ -675,6 +675,7 @@ impl BigInt { | |||
| return None; | |||
| } | |||
| match u64_digits.len() { | |||
| 0 => Some(to_bignum(0)), | |||
There was a problem hiding this comment.
unrelated to this PR, this was just a bug similar to the issue we had for serializing 0 as BigInt before.
this commit is just for the detailed schema (but has some parts of the basic/no-schema format) as I couldn't find test cases. Further commits will be made once I can get some test cases. Based on: https://github.com/input-output-hk/cardano-node/blob/c1efb2f97134c0607c982246a36e3da7266ac194/cardano-api/src/Cardano/Api/ScriptData.hs#L254 + using `cardano-cli`.
rooooooooob
force-pushed
the
plutus-datum-json-support
branch
from
be8542a
to
b20668b
Compare
SebastienGllmt
approved these changes
Feb 4, 2022
|
@lisicky : review and resolve conflicts plz |
# Conflicts: # rust/src/utils.rs
# Conflicts: # rust/src/utils.rs
# Conflicts: # rust/src/utils.rs
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements both JSON formats used by cardano-node/cardano-cli
Based on: https://github.com/input-output-hk/cardano-node/blob/c1efb2f97134c0607c982246a36e3da7266ac194/cardano-api/src/Cardano/Api/ScriptData.hs#L254