Pull upstream #16
Merged
Pull upstream #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, just for future code reusability
Since phi() is the probability that a pool is selected, we have to check whether we're *below* that number.
Fix above_stake_threshold and add genesis leadership selection test
…set-functions Extracted file-offset functions
nicarq
reviewed
May 24, 2019
| (big_pool_vrf_private_key, 0, Value(1000)), | ||
| ); | ||
|
|
||
| for _i in 0..10 { |
There was a problem hiding this comment.
nicarq
reviewed
May 24, 2019
|
|
||
| let nr_slots = slots_per_epoch; | ||
|
|
||
| for _i in 0..nr_slots { |
nicarq
reviewed
May 24, 2019
| let slots_per_epoch = 200000; | ||
| let active_slots_coeff = 0.1; | ||
|
|
||
| let (_genesis_hash, mut ledger) = create_initial_fake_ledger( |
There was a problem hiding this comment.
if this is not used, I think you can also just do _
There was a problem hiding this comment.
It's not used. marking it as _genesis_hash is done to both signify it is not used (so it doesn't trip the rustc unused variable linter), while also still documenting what it is we're iterating over.
This PR is also just updating our fork with IOHK's repo (thus this is their code) before we send them a PR back, so we don't want to be making needless changes which would just complicate our PRs in their repo.
All changes in this PR are also in the in-development/experimental shelley module which we are not using yet for the bridge or anything else.
Add function to get txid from not yet signed transaction (because it's needed for signing) Add function to get root xprv (to be able to derive the necessary private key for signing)
while this function should not be used to create a new ledger state it is necessary to have for the block content selection
…-changes Mockchain changes: LedgerParameters in the Leadership and apply_fragment
…p-helper-doc Leadership Helper and Doc
…ing-cleanup key evolution cleanup
…transaction-example IOHKCRB-34 Sign transaction example
Errors improvements
multiple secret key maps their public key to the same public key algorithm. Allow to specify public key as ed25519, regardless of the type of ed25519 (normal or extended)
use Ed25519 in public interfaces now adjustment linked to the new split in half constraint to traits
This fix ensures the actual output is "<addr>".
…ble_to_string
AddressReadable prints AddressReadable("<addr>")
…bkey-surjective Make pubkey surjective
…nt-autocreate register stake key on auto creation of account
…-imports remove unused imports
After this revision, the "tower-h2" feature no longer exists.
Require that the response streams produced by the service implementation satisfy Send + 'static. This reduces a lot of bound work for generic protocol implementations that require the streams to be sendable across threads. A future port of network-grpc to tower-hyper will be one such implementation.
This ContentService method was only used by network-ntt, and, if that protocol implementation is ever continued, it should be replaced with the implementation of message_subscription.
Require that any response futures the service implementation returns satisfy Send + 'static, just like the streams.
The tower-hyper port needs this, too.
…ervice-returns-sendable Send + 'static bounds for types returned by the network service implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling latest upstream after input-output-hk#704