mod - different error codes for tx/history

Emurgo · Jul 10, 2020 · 2c4f0e8 · 2c4f0e8
1 parent bea58f9
commit 2c4f0e8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -177,14 +177,16 @@ const txHistory = async (req: Request, res: Response) => {
 
             if(untilBlockNum.kind === 'error' && untilBlockNum.errMsg !== utils.errMsgs.noValue) {
               const msg = `untilBlockNum failed: ${untilBlockNum.errMsg}`;
-              throw new Error("txHistory: "+msg);
+              throw new Error("REFERENCE_BEST_BLOCK_MISMATCH");
               return;
             }
             if(afterBlockNum.kind === 'error' && afterBlockNum.errMsg !== utils.errMsgs.noValue) {
               const msg = `afterBlockNum failed: ${afterBlockNum.errMsg}`;
-              throw new Error("tsHistory: "+msg);
+              throw new Error("REFERENCE_TX_NOT_FOUND");
               return;
             }
+            // TODO: we should handle the case where body.after.tx is not in the 
+            //       reference block.
 
             const maybeTxs = await askTransactionHistory(pool, limit, body.addresses, afterBlockNum, untilBlockNum);
             switch(maybeTxs.kind) {

diff --git a/src/middleware/index.ts b/src/middleware/index.ts
@@ -22,5 +22,5 @@ export const logErrors = (err:Error, req: Request, res: Response, next: NextFunc
 };
 
 export const errorHandler = (err:Error, req: Request, res: Response, next: NextFunction) => {
-    res.status(500).send({ error: err.message });
+    res.status(500).send({ error: { response: err.message }});
 };