Add bignumber support #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppershing
reviewed
Oct 25, 2018
src/crypto/wallet.js
Outdated
| const fee = util.signTransaction(fakeWallet, inputs, outputs, changeAddress) | ||
| .fee | ||
| const fee = new BigNumber( | ||
| util.signTransaction(fakeWallet, inputs, outputs, changeAddress).fee, |
There was a problem hiding this comment.
Hmm, I wonder whether util.signTransaction shouldn't do this conversion...
ppershing
reviewed
Oct 25, 2018
| } | ||
|
|
||
| // Note(ppershing): upgrade to bignum once we use it | ||
| const _sum = (a: Array<{amount: number}>) => | ||
| a.reduce((acc, x) => acc + x.amount, 0) | ||
| const _sum = (a: Array<{amount: BigNumber}>): BigNumber => |
ppershing
reviewed
Oct 25, 2018
src/utils/transactions.js
Outdated
| const _sum = (a: Array<{amount: number}>) => | ||
| a.reduce((acc, x) => acc + x.amount, 0) | ||
| const _sum = (a: Array<{amount: BigNumber}>): BigNumber => | ||
| a.reduce((acc: BigNumber, x) => acc.plus(x.amount), new BigNumber(0, 10)) |
There was a problem hiding this comment.
why new Bignumber(0, 10) ?
ppershing
approved these changes
Oct 25, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.