feat(mat): Navigate to transaction start screen from token select #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljscript
commented
May 25, 2023
apps/wallet-mobile/src/features/Send/useCases/StartMultiTokenTx/StartMultiTokenTxScreen.tsx
Outdated
Show resolved
Hide resolved
michaeljscript
commented
May 25, 2023
michaeljscript
commented
May 25, 2023
...t-mobile/src/features/Send/useCases/ListAmountsToSend/AddToken/SelectTokenFromListScreen.tsx
Outdated
Show resolved
Hide resolved
michaeljscript
commented
May 31, 2023
banklesss
approved these changes
Jun 12, 2023
stackchain
reviewed
Jun 20, 2023
stackchain
requested changes
Jun 21, 2023
michaeljscript
commented
Jun 21, 2023
stackchain
requested changes
Jun 22, 2023
| @@ -189,6 +203,7 @@ const useNavigateTo = () => { | |||
| addToken: () => navigation.navigate('send-select-token-from-list'), | |||
| editAmount: () => navigation.navigate('send-edit-amount'), | |||
| confirmTx: () => navigation.navigate('send-confirm-tx'), | |||
| startTx: () => navigation.navigate('send-start-tx'), | |||
There was a problem hiding this comment.
update and import from common.
| @@ -24,7 +23,7 @@ export const StartMultiTokenTxScreen = () => { | |||
|
|
|||
| const {targets, selectedTargetIndex, receiverChanged, memo, memoChanged, addressChanged} = useSend() | |||
| const {address, amounts} = targets[selectedTargetIndex].entry | |||
| const shouldOpenSelectToken = Object.keys(amounts).length === 0 | |||
| const shouldOpenAddToken = Object.keys(amounts).length === 0 | |||
There was a problem hiding this comment.
my bad here, it should be using Amounts.toArray helper, amounts must be manipulated with this helper always.
stackchain
approved these changes
Jun 22, 2023
89 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves YOMO-515
Navigates to transaction start screen from asset select when the user has no selected assets and clicks on back. Otherwise, navigates to the list