New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
problem: logged out users can still access forms #393
Comments
solution : every form template needs to be included in a test about the login status of the user. |
@venatoria, you can also test this in the router, before rendering the template at all. It's maybe simpler. |
@anbud my first thought was to implement on the templates. |
@venatoria if you're working on this now, you should do |
@emurgobot claim |
Welcome to Zulip, @venatoria! We just sent you an invite to collaborate on this repository at https://github.com/EmurgoHK/cardanoupdate/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
1 similar comment
Welcome to Zulip, @venatoria! We just sent you an invite to collaborate on this repository at https://github.com/EmurgoHK/cardanoupdate/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
soluiton: add a filter to the routes related to the forms that triggers a check on login. this solves issue EmurgoHK#393
@emurgobot label "done" |
problem: logged out users can still access forms (issue #393)
Hey @venatoria You don't need to change label after sending PR you can just comment
This will automatically unassigned you and add label done :) |
problem: logged out users can still access forms, which will really annoying because users might fill out the form but then realize they are not logged in and lose all their work.
solution: send logged out users to login page whenever trying to access forms. All forms site wide must be checked.
The text was updated successfully, but these errors were encountered: