Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problem: weird menu layout on mobile #394

Closed
gsovereignty opened this issue Nov 1, 2018 · 4 comments
Closed

problem: weird menu layout on mobile #394

gsovereignty opened this issue Nov 1, 2018 · 4 comments
Labels
done Problem is solved, waiting for confirmation to close

Comments

@gsovereignty
Copy link
Member

problem: weird menu layout on mobile, kind of looks like a double menu.

solution: on mobile remove the menu with background image, users will probably know to use the side menu

screenshot 2018-11-01 at 4 20 53 pm
@MadanBhandari
Copy link
Member

@gazhayes instead of removing background image altogether, we can add black overlay or add shadow to text on mobile.

@gsovereignty
Copy link
Member Author

Oh I mean really remove the whole thing, including the menus. Since people will probably just use the side menu on mobile anyway

@MadanBhandari
Copy link
Member

Got it :)
@emurgobot claim

@emurgobot emurgobot added the in progress Someone is working on this issue label Nov 1, 2018
MadanBhandari added a commit to MadanBhandari/cardanoupdate that referenced this issue Nov 1, 2018
@MadanBhandari
Problem: weird menu layout on mobile EmurgoHK#394
7c948cb 
Solution : Extra menu layout on mobile removed
@MadanBhandari
Copy link
Member

@emurgobot done in #401

@emurgobot emurgobot added done Problem is solved, waiting for confirmation to close labels Nov 1, 2018
@emurgobot emurgobot removed in progress Someone is working on this issue labels Nov 1, 2018
gsovereignty added a commit that referenced this issue Nov 1, 2018
@gsovereignty
Merge pull request #401 from MadanBhandari/issue/394
93d1b8e 
Problem: weird menu layout on mobile #394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done Problem is solved, waiting for confirmation to close
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MadanBhandari @gsovereignty @emurgobot