Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Election Name to Undebate Page #30

Closed
ddfridley opened this issue Dec 2, 2019 · 0 comments
Closed

Add Election Name to Undebate Page #30

ddfridley opened this issue Dec 2, 2019 · 0 comments
Assignees
@beribak
Labels
Effort-small Looks like a small effort enhancement New feature or request React
Projects
Development & Project Management Development: Ballotpedia March Elections

Comments

@ddfridley
Copy link
Contributor

ddfridley commented Dec 2, 2019 •
edited

Add the election name (from the subject: field) to the top of the page. Make it format well on all device types.

The file is app/components/web-components/undebate.jsx
there will be a prop called subject
add it to either the function main() or to what render returns.

Then adjusting the placement of the windows (seats), agenda, and buttons. in calculatePositionAndStyle()

Note that initial values are set when state is initialized, and then recalculated when the viewport size is known based on the viewport proportions.

See also #25, it would be userful to make both changes at the same time.
@ddfridley ddfridley added Effort-small Looks like a small effort enhancement New feature or request labels Dec 2, 2019
@ddfridley ddfridley moved this from Ice Box to Prioritized Backlog in Development: Ballotpedia March Elections Dec 3, 2019
This was referenced Dec 3, 2019
Closed
Closed
@ddfridley ddfridley added the React label Dec 3, 2019
@beribak beribak self-assigned this Dec 15, 2019
@beribak beribak mentioned this issue Dec 17, 2019
Closed
beribak added a commit that referenced this issue Dec 17, 2019
@beribak
issue #30 portrait mode
265f487
@beribak beribak mentioned this issue Dec 17, 2019
Merged
ddfridley pushed a commit that referenced this issue Dec 18, 2019
@beribak @ddfridley
Issue#30 (#38)
c1eede9 
* no code changes

* header with conversation topic added and changes to styling of speaker and agenda boxes

* landscape mode layout corrected to reflect addition of header and button bar position adjusted in w/h > 1.8 screen size

* conversation topic layout

* yarn.lock added to gitignore

* issue #30 portrait mode

* gitignore yarn lock file sent on new lin
@ddfridley ddfridley moved this from Prioritized Backlog to In progress (actively working) in Development: Ballotpedia March Elections Dec 20, 2019
@ddfridley ddfridley moved this from In progress (actively working) to Done in Development: Ballotpedia March Elections Dec 20, 2019
Development & Project Management automation moved this from Ice Box to Done Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beribak beribak

Labels
Effort-small Looks like a small effort enhancement New feature or request React
Projects
Development & Project Management
  
Done
Development: Ballotpedia March Elections
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddfridley @beribak