Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Classification layer accuracy and area report] add support for non-matching category names #845

Closed
janzandr opened this issue Mar 18, 2024 · 4 comments · Fixed by #846
Closed
Assignees
Labels
feature request New feature or request priority: high

Comments

@janzandr
Copy link
Contributor

Currently, observed and predicted category names must match.
image

E.g. use this setup to reproduce the problem:
image

It is proposed to soften this restriction a bit, and to also allow category matching by order, if the number of categies is equal.

@janzandr janzandr added feature request New feature or request priority: high labels Mar 18, 2024
@janzandr janzandr added this to the Future Release milestone Mar 18, 2024
@janzandr janzandr self-assigned this Mar 18, 2024
@janzandr
Copy link
Contributor Author

@jakimowb any remarks from your side?

janzandr added a commit that referenced this issue Mar 18, 2024
@jakimowb
Copy link
Contributor

It need to be cristal clear which class matching. By now it seems to be on class names only.

grafik

Optimally the processing algorithm should support the following options:

  1. match on class names, e.g. if there is a raster and a reference shapefile with class names
  2. match on class numbers
  3. match on class order

The final report needs to show this as well, i.e. which used class names + numbers were compared.

@janzandr janzandr linked a pull request Mar 18, 2024 that will close this issue
@janzandr
Copy link
Contributor Author

Thanks @jakimowb, I will add a description to the docs and add the matching to the report.

@janzandr
Copy link
Contributor Author

FYI @jakimowb, done:

  1. Class matching is shown in a table:
    image

  2. For classes that can't be matched by name, a warning is logged:
    image

  3. Improved algo doc:
    image

janzandr added a commit that referenced this issue Mar 18, 2024
janzandr added a commit that referenced this issue Mar 18, 2024
…acy-and-area-report-add-support-for-non-matching-category-names

resolved #845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request priority: high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants