Added email notification for committee subscribers #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhamon
reviewed
Feb 2, 2017
|
|
||
| foreach ($followers as $follower) { | ||
| /** @var Adherent $follower */ | ||
| $this->mailJet->sendMessage(CommitteeFeedNotificationMessage::create($follower, $message)); |
There was a problem hiding this comment.
You must send only one message with multiple recipients. See how I've done it with the events.
HeahDude
force-pushed
the
feat/send-event-message
branch
from
7afe4bb
to
28ab47a
Compare
hhamon
approved these changes
Feb 3, 2017
HeahDude
force-pushed
the
feat/send-event-message
branch
from
28ab47a
to
5fdd94e
Compare
tgalopin
reviewed
Feb 3, 2017
| use Doctrine\Common\Persistence\ObjectManager; | ||
|
|
||
| class CommitteeFeedHandler | ||
| { | ||
| private $manager; | ||
| private $committeeManager; | ||
| private $mailJet; |
HeahDude
added a commit
that referenced
this pull request
Feb 3, 2017
…Dude) This PR was merged into the master branch. Discussion ---------- Added email notification for committee subscribers Closes [EM-48](http://jira.sensiolabs.net/browse/EM-48). Commits ------- 5fdd94e Added email notification for committee subscribers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EM-48.