added je-marche form #308
added je-marche form #308
Conversation
| /** | ||
| * @var string | ||
| * | ||
| * @ORM\Column(name="actionType", type="string", length=50) |
There was a problem hiding this comment.
Please remove all the columns names and all the column types if they are strings.
| 'L\'atelier du projet' => 'L\'atelier du projet', | ||
| 'L\'action qui me ressemble' => 'L\'action qui me ressemble' | ||
| ), | ||
| 'attr' => array('class' => 'form--full') |
There was a problem hiding this comment.
There is an issue in identation here and at some other places in this file.
| $builder | ||
| ->add('actionType', ChoiceType::class, array( | ||
| 'choices' => array( | ||
| 'La marche' => 'La marche', |
There was a problem hiding this comment.
I think we should put canonical identifiers here instead of classical strings (ie la-marche instead of La marche to ensure a proper database storage).
| /** | ||
| * JemarcheReport | ||
| * | ||
| * @ORM\Table(name="jemarche_report") |
There was a problem hiding this comment.
Can you put the table name in plural form (jemarche_reports) to follow the convention?
| use Doctrine\ORM\Mapping as ORM; | ||
|
|
||
| /** | ||
| * JemarcheReport |
There was a problem hiding this comment.
You can remove this line.
| /** | ||
| * @var string | ||
| * | ||
| * @ORM\Column(name="almostConvincedContact", type="text") |
There was a problem hiding this comment.
You need to add asserts for form validation (I suppose you were planning it :) ).
| public function configureOptions(OptionsResolver $resolver) | ||
| { | ||
| $resolver->setDefaults(array( | ||
| 'data_class' => 'AppBundle\Entity\JemarcheReport' |
There was a problem hiding this comment.
Please use the JemarcheReport::class notation.
| { | ||
| return 'appbundle_jemarchereport'; | ||
| } | ||
|
|
There was a problem hiding this comment.
You can remove these empty lines.
| */ | ||
| public function getBlockPrefix() | ||
| { | ||
| return 'appbundle_jemarchereport'; |
There was a problem hiding this comment.
app_jemarchereport (to follow convention)
| */ | ||
| public function newAction(Request $request) | ||
| { | ||
| $jemarcheReport = new Jemarchereport(); |
There was a problem hiding this comment.
Isn't it JemarcheReport ?
| /** | ||
| * @var string | ||
| * | ||
| * @ORM\Column(name="convincedContact", type="text") |
There was a problem hiding this comment.
SQL column names must be in snake_case, so the name attribute can be removed.
|
fixed |
Bonjour,
J'ai fais une première version du formulaire "je-marche".