Agent performance improvements #5281

k-wall · 2021-03-14T19:04:52Z

Type of change

Refactoring

Description

Small performance improvements to the Agent around connection/address registry to lower CPU utilisation.

Checklist

Update/write design documentation in ./documentation/design
Write tests and make sure they pass
Update documentation
Check RBAC rights for Kubernetes / OpenShift roles
Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
Reference relevant issue(s) and close them after merging
Update CHANGELOG.md

avoids the need for repetitious JSON based equality comparison once a object is found to be updated.

filter out drifting creationTimestamp

cryptographic secrity is not a requirement, so the extra computational overhead can be avoided.

k-wall · 2021-03-14T19:17:58Z

Whilst working on #5226 (which I decided not to take forward) I noticed a few areas of agent's connection/address that could be optimised for (slightly) better performance/lower CPU utilisation.

rgodfrey

LGTM

k-wall added the component/agent label Mar 14, 2021

k-wall requested a review from rgodfrey March 14, 2021 19:09

k-wall added 5 commits March 14, 2021 19:14

Fix EnMasseProject#5226: short circuit registry equality

f9d3ee9

avoids the need for repetitious JSON based equality comparison once a object is found to be updated.

consider only ones own properties

cbf8132

avoid considering functions when evaluating connection object equality

b11abb3

filter out drifting creationTimestamp

use sha-1 when creating object identities (rather than sha-256)

c3fd335

cryptographic secrity is not a requirement, so the extra computational overhead can be avoided.

avoid iteration when testing for internal connections

8ce020c

k-wall force-pushed the issue-5226-v2 branch from 2ad7a41 to 8ce020c Compare March 14, 2021 19:14

rgodfrey approved these changes Mar 16, 2021

View reviewed changes

k-wall merged commit d1cdf70 into EnMasseProject:master Mar 16, 2021

k-wall added a commit that referenced this pull request Mar 16, 2021

Add #5281 to chglog

d3a9136

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Agent performance improvements #5281

Agent performance improvements #5281

k-wall commented Mar 14, 2021

k-wall commented Mar 14, 2021 •

edited

rgodfrey left a comment

Agent performance improvements #5281

Agent performance improvements #5281

Conversation

k-wall commented Mar 14, 2021

Type of change

Description

Checklist

k-wall commented Mar 14, 2021 • edited

rgodfrey left a comment

Choose a reason for hiding this comment

k-wall commented Mar 14, 2021 •

edited