This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Upgrade Azure Service Bus to 5.2.0 #47
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryGaoE
commented
Jan 9, 2023
| @@ -73,7 +73,7 @@ public class AzureServiceBusQueueClient : BaseQueueClient | |||
| // This timeout is arbitrary. It is needed in order to return null | |||
| // if no messages are queued, and must be long enough to allow time | |||
| // for connection setup. | |||
| var message = await _messageReceiver.ReceiveAsync(TimeSpan.FromSeconds(10)); | |||
| var message = await _messageReceiver.ReceiveAsync(TimeSpan.FromSeconds(5)); | |||
There was a problem hiding this comment.
This was necessary as 10 seconds was too long to return null if no messages were queued.
Based on a few tests, it was determined that 5 seconds consistently allows for null messages from empty queues to be picked up. After 6+ seconds, it was determined that it can prevent these null messages.
As stated in the comment, this is an arbitrary value and needs to be:
- Short enough to allow nulls
- Long enough to allow for connection setup.
All tests pass with this change. However, it's not possible to do local testing due to the need for Azure resources.
Therefore, I believe it's necessary to test the changes on Dev using the DealTrack API.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Azure Service Bus to 5.2.0, which is required for some .NET 6 upgrades.