ec-555 #294
Merged
ec-555 #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromel777
reviewed
Mar 5, 2019
| syntax = "proto3"; | ||
| import "scalapb/scalapb.proto"; | ||
|
|
||
| option optimize_for = SPEED; |
There was a problem hiding this comment.
not necessary to set optimize_for to speed
Bromel777
reviewed
Mar 5, 2019
| case Payload.`modifierTypeId` => PayloadSerializer.parseBytes(bytes.tail) | ||
| case m => Failure(new Exception(s"Deserialization for unknown type byte: $m")) | ||
| } | ||
| def fromProto(bytes: Array[Byte]): Try[EncryPersistentModifier] = Try(bytes.head).flatMap { |
There was a problem hiding this comment.
you can match bytes head directly
Bromel777
reviewed
Mar 6, 2019
| case MessageFromNetwork(message, Some(remote)) => | ||
| message match { | ||
| case message@SyncInfoNetworkMessage(_) => | ||
| findHandler(message, NetworkMessagesIds.SyncInfo, remote, messagesHandlers) |
There was a problem hiding this comment.
add check for data size (objects qty)
Bromel777
reviewed
Mar 7, 2019
src/main/resources/application.conf
Outdated
| logger-startup-timeout = 60s | ||
| loggers = ["akka.event.slf4j.Slf4jLogger"] | ||
| actor.warn-about-java-serializer-usage = false | ||
| persistence { |
Bromel777
reviewed
Mar 7, 2019
| transferDirectiveWithoutTokenIdFromProto.get.tokenIdOpt shouldBe None | ||
| } | ||
|
|
||
| property("Transaction should be serialized correctly") { |
Bromel777
reviewed
Mar 7, 2019
| @@ -103,37 +102,41 @@ class PeerConnectionHandler(messagesHandler: MessageHandler, | |||
| peerManager ! Handshaked(peer) | |||
| handshakeTimeoutCancellableOpt.map(_.cancel()) | |||
| connection ! ResumeReading | |||
| logger.info(s"Context become workingCycle on peerHandler") | |||
Bromel777
reviewed
Mar 7, 2019
| mH.find(_._1.contains(messageId)).map(_._2) match { | ||
| case Some(handler) => | ||
| handler ! DataFromPeer(message, remote) | ||
| logger.info(s"Send message DataFromPeer with ${message.messageName} to $handler.") |
GRYE
reviewed
Mar 10, 2019
| @@ -26,6 +28,8 @@ class MinerWalletBalanceTest extends AsyncFunSuite with Matchers with NodesFromD | |||
|
|
|||
| val height = dockerNodes().head.waitForHeadersHeight(heightToCheck) | |||
| Await.result(height, 30.minutes) | |||
| val boxes: Seq[EncryBaseBox] = Await.result(dockerNodes().head.outputs, 30.minutes) | |||
| val oneBox: AssetBox = boxes.collect { case ab: AssetBox => ab }.head | |||
There was a problem hiding this comment.
This val is not used anywhere (same as one above)
Bromel777
reviewed
Mar 11, 2019
| val syncInfoToProto: GeneralizedNetworkProtoMessage.InnerMessage = syncInfoBeforeProto.toInnerMessage | ||
| val syncInfoFromProto: Option[SyncInfoNetworkMessage] = SyncInfoNetworkMessageSerializer.fromProto(syncInfoToProto) | ||
|
|
||
| val comparison: Set[Boolean] = syncInfoFromProto.get.esi.lastHeaderIds.map(id => |
There was a problem hiding this comment.
you can use forall instead of map
Bromel777
reviewed
Mar 11, 2019
| case Failure(e) => logger.error(s"Failed to deserialize data: $e") | ||
| } | ||
| case MessageFromNetwork(message, Some(remote)) if message.isValid(settings) => | ||
| logger.info(s"Got ${message.messageName} on the NetworkController.") |
Bromel777
approved these changes
Mar 11, 2019
GRYE
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.