[Feature]: Add compact representations for input/output. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Optimized the call to compactNumber() for better efficiency. * Simplified the moneyFormat() code to handle compaction logic more effectively. * Added an isNumeric() extension check to handle NaN cases gracefully. * Removed unnecessary code to enhance codebase maintainability. Bugfixes: * Now handling NaN values. * Prevent null from compactChar in money suffix. * Always add currencyName to suffix.
* Added extension String.isDecimal(), checking valid numeric Doubles * Replaced isNumeric() call for isDecimal(), fixing issue where decimal points return null. * Small refactor of compactNumber, replaced if-else with takeIf + let
* Replaced if-else with takeIf. * Removed redundant "this" keywords. * Added "Q" in compactNumber for Quadrillion display. * Removed NOT operator in "isFinite()" check to correct bool value.
|
Foolproofing: Usage There may be a problem when it rounds compact numbers for example "10.928M" to "10.93M" However this only happens to the output, the real value is still correct. |
|
@EncryptSL What do you think of these changes? Sorry i made excessive commits. |
|
Changes looks good. |
|
Thanks, i'm working in other plugins but i'm still contributing to this plugin I will upload the new pull request of this feature soon. |
|
Yep no problem |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature Request]: Compact representations using metric prefixes #52 ✅
Implemented compact representations for input with
validateAmount().Implemented compact representations for output/display in
liteEco.api.formatting()Refactored repeated code for amount validation with
validateAmount()Implemented temporal translation for
format_amount_errorAdded config
plugin.economy.compact_displayto toggle compact representations for output.