Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how Github token is retrieved #110

Closed
Cyberbeni opened this issue Dec 18, 2020 · 2 comments · Fixed by #112
Closed

Change how Github token is retrieved #110

Cyberbeni opened this issue Dec 18, 2020 · 2 comments · Fixed by #112
Assignees
Labels
type: feature New feature or feature request

Comments

@Cyberbeni
Copy link
Contributor

Cyberbeni commented Dec 18, 2020

It works fine for me without the token: https://github.com/Cyberbeni/ShowTouches/runs/1579363839?check_suite_focus=true#step:5:63

There is also this similar action that gets GITHUB_TOKEN like this: https://github.com/peter-evans/create-pull-request/blob/master/action.yml#L4-L6

Edit: it works without the token because I checked out the repo before and that also got the token the same way as the other action: https://github.com/actions/checkout/blob/main/action.yml#L12-L24

@Cyberbeni Cyberbeni added the status: pending More info is needed before deciding what to do label Dec 18, 2020
@EndBug
Copy link
Owner

EndBug commented Dec 19, 2020

Hi, thanks for the issue. I've actually noticed this too, but didn't think about it too much.
It's would be a good idea to get the token as that action does

@EndBug EndBug added type: feature New feature or feature request and removed status: pending More info is needed before deciding what to do labels Dec 19, 2020
@EndBug EndBug self-assigned this Dec 19, 2020
@EndBug EndBug changed the title Action works without GITHUB_TOKEN Change how Github token is retrieved Dec 19, 2020
@EndBug
Copy link
Owner

EndBug commented Dec 22, 2020

The fix has been included in v6.1.0 (also v6 and latest), thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants