-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action fails when add
or remove
only contain a space
#154
Comments
seems like this would be a problem for me with add as well if I had only deleted files |
Hi, thanks for the report! You're right, you could do separate steps with checks, but it's really counter-intuitive that an empty string causes the action to fail, also because the default value for |
hmm, strange... it's not just that maybe, I split it into 2 actions, and add still blows up, trim might still fix it though.
|
I'm going to bed, too tired to know what I'm talking about, but in the event it helps, this is my current full source code (in this branch) https://github.com/xenoterracide/iw-ppm-backend/tree/ccushing/plantuml . this comment will of course eventually be stale. |
I think I fixed the issue. The fix is currently on the - uses: EndBug/add-and-commit@master
with: ... |
sorry I haven't tested this yet (sort of) I've been tracking down other bugs whilst trying to ensure this is working... and found many in my code. Not certain if this is part of this though, but it's kind of frustrating that something is being passed, but the build is not failing when it's missing.
|
The action will not stop if git commands fail because they don't match any file, this is intended behavior. Please test |
Oh, I got it tested last night finally. It seems to work now
…On Sat, Apr 3, 2021, 9:00 AM Federico Grandi ***@***.***> wrote:
The action will not stop if git commands fail because they don't match any
file, this is intended behavior.
If you want the workflow run to fail in this situation you'll have to
either run a custom command or use an action like [this].(
https://github.com/marketplace/actions/file-existence)
Please test ***@***.*** as soon as you can, thank you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#154 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAABLDKMBU3YIVUJE6UQ3TLTG4NRRANCNFSM42BLE6IQ>
.
|
@all-contributors please add @xenoterracide for their bug report |
I've put up a pull request to add @xenoterracide! 🎉 |
I've published the fix in |
I suppose what I could do here is simply have 2 steps with conditionals, but that would end up with 2 commits which seems less elegant. Might be nice if it checked for empty and then did nothing on empty (except maybe log a warning).
The text was updated successfully, but these errors were encountered: