New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support collections as values for add
, rm
and so on
#95
Comments
add
, rm
and so onadd
, rm
and so on
add
, rm
and so onadd
, rm
and so on
Seems like a good idea, I'll try to add it as soon as I manage to find the time to ;) |
Hi, I've looked into adding it, but it seems like GH actions inputs only support strings: the only thing I can do is parsing a JSON/YAML array from them. |
Well, that's a bummer. And yeah, probably parsing from JSON or so is the best way to go. It also seems like this is the way other people do it, since it does not seem like this feature will be added in the near future. From what I understand the inputs are available as env vars within the action. Btw I personally don't need that feature atm, so don't rush yourself or anything like that 😄 |
Yeah exactly, in the code their accessed as env variables. |
This issue is being marked as "stale" because it has been open 20 days with no activity. Remove the "stale" label or comment, otherwise this will be closed in 5 days. |
* feat: support arrays as add/remove inputs re #95 * chore: add debug log for parsed input type
@all-contributors please add @trallnag for their idea |
I've put up a pull request to add @trallnag! 🎉 |
Ok, I've added this change in a new major version. I've decided to use a major bump just because, even though the previous input format is still valid, this could technically break some commands. The new version is |
Hello, I think it would improve usability if we could use multiple
git add
commands with within a single action. For example:This wouldn't even be a breaking change if both collections and scalars are supported.
At the moment it is possible to to it like this
git add file-1 file-2 file-3
, which translates toadd: file-1 file-2 file-3
, but what if the path has a space in it?The text was updated successfully, but these errors were encountered: