Support a custom working directory #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows users to optionally specify which directory has the git repository. In rare cases, the directory containing the desired repository does not exist within the github workspace on a runner. When this occurs, this action is no longer useable. The `working-directory` option within a workflow is only supported for `run` steps and not `uses`: https://stackoverflow.com/questions/67299058/running-github-actions-for-uses-in-another-directory
qubitz
commented
Jul 10, 2023
|
Nice idea! When you're ready, mark the PR as "Ready for review" and I'll take a look at it ;) |
|
@EndBug have you had a chance to look at this? |
EndBug
requested changes
Sep 1, 2023
There was a problem hiding this comment.
Hi! Sorry but I didn't receive the notification when you marked the PR as ready for review 😅
Anyway, just looked at it and it's great! I just have one note about the setupUser function, can you take a look at the review comment?
As soon as that's fixed, I'll test the action, marge the PR, and release a new minor version 🚀
Co-authored-by: Federico Grandi <fgrandi30@gmail.com>
|
Okay, I think these changes are ready to go. TIA for testing it 👍. |
|
@all-contributors please add @qubitz for their code contribution ✨ |
|
I've put up a pull request to add @qubitz! 🎉 |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to optionally specify which directory has the git repository.
In rare cases, the directory containing the desired repository does not exist within the github workspace on a runner. When this occurs, this action is no longer useable.
The
working-directoryoption within a workflow is only supported forrunsteps and notuses:https://stackoverflow.com/questions/67299058/running-github-actions-for-uses-in-another-directory
I am fairly new to TypeScript and would welcome any feedback.