Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with Pull Request event commit handling #14

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Fix issue with Pull Request event commit handling #14

merged 2 commits into from
Apr 16, 2020

Conversation

hmehta
Copy link
Contributor

@hmehta hmehta commented Apr 14, 2020

  • Fix issue where triggering this Action on Pull Request event caused unhandled exception
  • Fetches actual commits for PR events using GitHub API

@hmehta
Fix issue with Pull Request event commit handling
e09a6ec 
* Fix issue where triggering this Action on Pull Request event caused unhandled exception
* Fetches actual commits for PR events using GitHub API
@hmehta
Bump version
aa30107
@EndBug EndBug added the type: bug Verified problems that need to be worked on label Apr 14, 2020
@EndBug EndBug added this to In progress in Main board via automation Apr 14, 2020
@EndBug
Copy link
Owner

EndBug commented Apr 14, 2020

Thank you, this is awesome!
Just give me some time to test everything and then I'll publish it 👍

@hmehta
Copy link
Contributor Author

hmehta commented Apr 14, 2020

Thank you, this is awesome!
No probs, just noticed this when trying to utilize your Action and instead of just ranting for it not working I thought I'd spend some time to actually provide a fix for the bug I found :)

Thank you for writing the initial version of this action!

Just give me some time to test everything and then I'll publish it +1

Yeah, just take your time and check the version bump / built library / whatever your normal actions run on the repository - I just made manual bump commit and uploaded my work.

@EndBug EndBug merged commit ef03512 into EndBug:master Apr 16, 2020
Main board automation moved this from In progress to Done Apr 16, 2020
@EndBug EndBug mentioned this pull request Apr 16, 2020
Closed
@EndBug
Copy link
Owner

EndBug commented Jul 13, 2020

@all-contributors please add @hmehta for code

@allcontributors allcontributors bot mentioned this pull request Jul 13, 2020
Merged
@allcontributors
Copy link
Contributor

@EndBug

I've put up a pull request to add @hmehta! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug Verified problems that need to be worked on
Projects
No open projects
Main board
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hmehta @EndBug