Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkAnalysis feature added to CLI #26

Merged
merged 1 commit into from Jul 10, 2021

Conversation

mrbazzan
Copy link
Contributor

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 29, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.90%.

Quality metrics Before After Change
Complexity 7.19 ⭐ 8.29 ⭐ 1.10 👎
Method Length 27.65 ⭐ 30.95 ⭐ 3.30 👎
Working memory 6.20 🙂 5.95 ⭐ -0.25 👍
Quality 77.16% 76.26% -0.90% 👎
Other metrics Before After Change
Lines 305 369 64
Changed files Quality Before Quality After Quality Change
pyanchor/init.py 100.00% ⭐ 100.00% ⭐ 0.00%
pyanchor/cli.py 56.23% 🙂 52.85% 🙂 -3.38% 👎
pyanchor/link_checker.py 81.65% ⭐ 81.12% ⭐ -0.53% 👎
tests/test_cli.py 98.77% ⭐ 98.06% ⭐ -0.71% 👎
tests/test_link_checker.py 98.00% ⭐ 98.03% ⭐ 0.03% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pyanchor/cli.py analysis 27 😞 167 😞 9 🙂 40.95% 😞 Refactor to reduce nesting. Try splitting into smaller methods
pyanchor/cli.py main 15 🙂 141 😞 10 😞 49.84% 😞 Try splitting into smaller methods. Extract out complex expressions
pyanchor/cli.py print_results 18 🙂 99 🙂 10 😞 52.71% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #26 (2e65e62) into master (2293404) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   99.19%   99.30%   +0.11%     
==========================================
  Files           3        3              
  Lines         124      144      +20     
==========================================
+ Hits          123      143      +20     
  Misses          1        1              
Impacted Files Coverage Δ
pyanchor/__init__.py 100.00% <ø> (ø)
pyanchor/cli.py 98.66% <100.00%> (+0.48%) ⬆️
pyanchor/link_checker.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2293404...2e65e62. Read the comment docs.

@EndlessTrax
Copy link
Owner

Thank you for all you hard work, @mrbazzan. It looks good.

I think I need to reimagine the cli commands. I like that you added analysis command, but main feels wrong, so I might have to change the default cli commands.

Breaking changes to the cli should be in a 1.0 release, so would you mind changing this PR to merge with the dev branch instead of master please? Then I'd be happy to merge and make it part of the 1.0 release.

@EndlessTrax EndlessTrax self-requested a review July 9, 2021 02:16
@EndlessTrax EndlessTrax linked an issue Jul 9, 2021 that may be closed by this pull request
@mrbazzan mrbazzan changed the base branch from master to dev July 10, 2021 09:40
@mrbazzan
Copy link
Contributor Author

Done!

@EndlessTrax EndlessTrax merged commit 09a3d54 into EndlessTrax:dev Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LinkAnalysis feature to CLI
2 participants