Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add correlation id to EDI response #2136

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ebbeknudsen
Copy link
Contributor

@ebbeknudsen ebbeknudsen commented Apr 16, 2024

Description

When receiving a request from EDI and sending a reply, the Wholesale subsystem now adds the incoming ServiceBusMessage.MessageId to the ServiceBusMessage.CorrelationId of the reply, based on https://learn.microsoft.com/en-us/azure/service-bus-messaging/service-bus-messages-payloads#message-routing-and-correlation (Simple request/reply)

Pull-request quality

  • The title adheres to this guide
  • Tests are written and executed locally
  • Subsystem tests have been tested (by manually deploying to dev_002)
  • Documentation has been updated
  • The integration event catalog has been updated
  • C4 diagrams have been updated and Team Outlaws has been informed about relevant changes

Copy link

gitguardian bot commented Apr 23, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant