Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax improvement project #562

Open
1 of 15 tasks
DandelionSprout opened this issue Sep 5, 2020 · 6 comments
Open
1 of 15 tasks

Syntax improvement project #562

DandelionSprout opened this issue Sep 5, 2020 · 6 comments
Labels
help wanted Extra attention is needed. Syntax problem Broken or non-ideal syntaxes in list versions

Comments

@DandelionSprout
Copy link
Contributor

DandelionSprout commented Sep 5, 2020

So in the past few months I had begun to notice that there were many issue reports on GitHub about substantial problems with list version syntaxes, so I decided to begin volunteering to try to fix it, which is currently going pretty poorly even after I got pull/merge privileges on GitHub. So as far as I am personally concerned, it's time to make a solid checklist so I won't have to check in on 20 different issue reports to remember what I wanted to fix, and to easier show what I need help from Ador and badmojr with.

Stage 1 (Most important)

  • Become able to see the [Travis / Azure Pipeline / whatever else] logs for the list generator script(s).
  • Make the list generator recognise changes made to build.sh and filter.sh scripts on GitHub.

Stage 2

Stage 3

Website-related bonus stuff

@DandelionSprout DandelionSprout added help wanted Extra attention is needed. Syntax problem Broken or non-ideal syntaxes in list versions labels Sep 5, 2020
@ghost
Copy link

ghost commented Sep 5, 2020

@DandelionSprout
Copy link
Contributor Author

DandelionSprout commented Sep 5, 2020

Okay, so it turns out that the extent to which the GitHub files are ignored by Energized, is far bigger than I initially believed (My initial beliefs was that I had somehow broke something when writing #560).

In particular, #530 still hasn't gone live after more than 3 weeks, which not only means that Energized is still blocking Falun Gong domains due to the political beliefs of neoHosts Full; but also that the past 48 hours of my life that I spent on this repo was a complete waste.

Either Ador needs to set a lot of things straight here within the next few days and explain how (and/or make it easier) to contribute to Energized, or I'm leaving this project.

@kah0922
Copy link

kah0922 commented Sep 6, 2020

I think this is probably the best place to mention this, but the adblock lists need to be simplified. For example, in the blu list, there is the rule ||pushwoosh.com^, yet there are 66 other entries in that list that all end with pushwoosh.com, even though the adblock syntax would block all of it due to the ||pushwoosh.com^ rule. An even worse example is ||siteintercept.qualtrics.com^, where subdomains of that site account for 771 rules, and that's not accounting for the 4327 hits for instances of qualtrics.com domains, which at that point you might as well just add a rule for ||qualtrics.com^.

Edit: Also there's a whole bunch of instances where there's ||badsite.com and then ||www.badsite.com. Once again, adblock syntax takes care of this. There are 11,517 instances of ||www. in the blu list, and they're all completely redundant rules.

@ghost ghost mentioned this issue Sep 11, 2020
5 tasks
@DandelionSprout
Copy link
Contributor Author

DandelionSprout commented Oct 11, 2020

Okay, so with Ador having been AFK for a month and a half now without doing even cursory checks of reported issues (Many of them very critical), my patience is done for. There is no way I can salvage a project whose salvation methods can only be accessed by one man who is AFK for weeks or months at a time.

My involvement as an Energized Protection team member is hereby over.

@ghost
Copy link

ghost commented Oct 11, 2020

Too bad, really, but cannot be helped then. It seems that even just reporting false positives a/o syntax issues is a waste of time under the circumstance.

@AvinashReddy3108
Copy link

AvinashReddy3108 commented Oct 15, 2020

Okay, so with Ador having been AFK for a month and a half now without doing even cursory checks of reported issues (Many of them very critical), my patience is done for. There is no way I can salvage a project whose salvation methods can only be accessed by one man who is AFK for weeks or months at a time.

My involvement as an Energized Protection team member is hereby over.

We'll be sad to see you go away like that. How about you and I work together while Ador's AFK?
Feel free to ping me on Telegram: @AvinashReddy3108 is my username there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed. Syntax problem Broken or non-ideal syntaxes in list versions
Projects
None yet
Development

No branches or pull requests

3 participants