Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error definitions #36

Closed
Enet4 opened this issue May 17, 2020 · 0 comments · Fixed by #62
Closed

Improve error definitions #36

Enet4 opened this issue May 17, 2020 · 0 comments · Fixed by #62
Assignees

Comments

@Enet4
Copy link
Owner

Enet4 commented May 17, 2020

Although error types are already statically delimited, errors emerging from the library currently contain little to no context about where they happened. This is an example of an error value which may emerge when opening a file: DataSetSyntax(PrematureEnd)

Requesting a backtrace is not useful because the error was raised with the ? operator, without keeping the full backtrace from the origin of the error at the library level. quick-error has been originally employed as a means to easily create error types, but for a solution of this scale, it becomes harder to work with and does not contribute to good errors.

As declared in the roadmap, it is of my interest to change the existing error definitions to something more informative and organized. I will try to rewrite existing errors with the use of another crate (likely either snafu or thiserror), which will provide the much needed quality of these error values.

@Enet4 Enet4 self-assigned this May 17, 2020
@Enet4 Enet4 mentioned this issue Aug 21, 2020
3 tasks
@Enet4 Enet4 closed this as completed in #62 Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant