Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging foundation #49

Closed
2 tasks done
Enet4 opened this issue Jun 7, 2020 · 0 comments
Closed
2 tasks done

Logging foundation #49

Enet4 opened this issue Jun 7, 2020 · 0 comments
Assignees
Labels
A-lib Area: library

Comments

@Enet4
Copy link
Owner

Enet4 commented Jun 7, 2020

As defined in the roadmap, some situations while working with DICOM data may not be critical to impose a soft error or panic, but should still be called out in some way. Logging comes to play as a non-invasive mechanism to report abnormal situations which do not impede the process, but may bring other issues along the way. As such, it is still relevant to provide this information to developers and to end users of CLI tools.

The two phases for fulfilling this issue would be:

  • Decide on a logging API for all library crates (as a façade to an actual logger implementation which can be decided by dependents). I believe this would be narrowed down to choosing between log, slog, or tracing.
    • tracing it is.
  • Choose a logging implementation for each existing CLI tool (dicom-dump, dicom-scproxy, and so on). One that prints to stdout/stderr would suffice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lib Area: library
Projects
None yet
Development

No branches or pull requests

1 participant