Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy getter methods for the file meta table #70

Closed
Enet4 opened this issue Sep 27, 2020 · 2 comments
Closed

Easy getter methods for the file meta table #70

Enet4 opened this issue Sep 27, 2020 · 2 comments
Labels

Comments

@Enet4
Copy link
Owner

Enet4 commented Sep 27, 2020

The attributes in the struct dicom_object::meta::FileMetaTable retain the padding from the encoded DICOM file meta group, and so they are usually padded for even length, even when built via the builder. While this makes it easy to serialize, it is not very useful when inspecting the attributes.

This calls for new methods to FileMetaTable which automatically trim the padding character out before returning the string slice.

Example signature (should be one per textual attribute):

fn transfer_syntax(&self) -> &str { unimplemented!() }
@PierreBou91
Copy link
Contributor

Hi @Enet4 ,
I was browsing the good first issues to try to improve my Rust and dicom understanding when I saw this one.
When I went to the FileMetaTable methods, I could see that you added the getter in this commit and that it was merged.

So my question is the following, is it just that this issue should be closed or is there some more work I could help with ? If it's the case, could you provide a bit of guidance as to where I should start to handle this issue ?

Thanks a lot,

Pierre

@Enet4
Copy link
Owner Author

Enet4 commented Apr 17, 2023

@PierreBou91 You're right, I ended up adding these helper methods over time. Thanks for the heads up.

There are a few other issues with the good first issue label, such as #46, but if you are interested in tackling some other task recorded here, feel free to let me know through that issue or reach out to me on Zulip.

@Enet4 Enet4 closed this as completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants