Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to LispReader$StringReader breaks with feature expressions patch #90

Closed
MichaelBlume opened this issue Jan 26, 2015 · 6 comments · Fixed by #94
Closed

Call to LispReader$StringReader breaks with feature expressions patch #90

MichaelBlume opened this issue Jan 26, 2015 · 6 comments · Fixed by #94

Comments

@MichaelBlume
Copy link
Contributor

This may be a premature issue, but I thought a heads-up might be useful; the feature expressions patch under discussion for inclusion in Clojure 1.7.0 changes the arity of LispReader$StringReader objects when they are called as functions, causing instaparse's safe-read-string to crash. I reported this on the clojure development board and the response was basically that this was deep enough in Clojure internals that it should be expected to break.

http://dev.clojure.org/jira/browse/CLJ-1424

@Engelberg
Copy link
Owner

Thanks for the heads up. Fortunately, it sounds like if it's just an arity change, it will be easy to fix when the time comes.

@MichaelBlume
Copy link
Contributor Author

Update: This is in 1.7.0-alpha6

MichaelBlume added a commit to MichaelBlume/instaparse that referenced this issue Mar 31, 2015
CLJ-1424 changed the arity of LispReader$StringReader in order to
support reader conditionals. This patch checks, at load time, which
arity is available, and wraps its string-reader accordingly.

Fix Engelberg#90

check is at load time so should be fast
@bitnovus
Copy link

@MichaelBlume
Thanks for the update.

@Engelberg
We'd love to see this issue resolved soon! We use Instaparse through Compojure and our builds are breaking with Clojure 1.7.0-alpha6. Thanks for your hard work!

@kanwei
Copy link

kanwei commented Mar 31, 2015

+1

@seancorfield
Copy link

Yes, another +1 here -- this just broke our build since we routinely test against Clojure master (which now includes the changes from Alpha 6).

@seancorfield
Copy link

Confirmed this works with Clojure master now for our unit tests. Thank you! Next step is to upgrade our whole stack to Clojure 1.7.0-alpha6 and run a full stack test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants