Retain rule and alternation comments. #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See test/instaparse/retain_comments.cljc for examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion for one possible approach to retaining comments in the parsed grammar (issue #178). This adds a new :comments field to nodes in the tree. Comments that are inside rules are attached to alternation nodes. Comments that are determined to be outside of rules (top-level) are attached to the next rule. The :comments value is a sequence of strings. Multiple comments at the same point in the grammar are separate strings in the :comments sequence. I'm new to the instaparse internals so this likely isn't the most optimal or least intrusive way to implement this so I'm proposing this to get a review/feedback on the change.