Ensure we flush iff it is needed

EngineHub · Oct 21, 2018 · d1312c6 · d1312c6
1 parent a3f1c71
commit d1312c6
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/EditSession.java b/worldedit-core/src/main/java/com/sk89q/worldedit/EditSession.java
@@ -415,7 +415,7 @@ public void setBatchingChunks(boolean batchingChunks) {
             }
             return;
         }
-        if (!batchingChunks) {
+        if (!batchingChunks && isBatchingChunks()) {
             flushSession();
         }
         chunkBatchingExtent.setEnabled(batchingChunks);
@@ -428,9 +428,15 @@ public void setBatchingChunks(boolean batchingChunks) {
      * @see #setBatchingChunks(boolean)
      */
     public void disableBuffering() {
-        // We optimize here to avoid double calls to flushSession.
+        // We optimize here to avoid repeated calls to flushSession.
+        boolean needsFlush = isQueueEnabled() || isBatchingChunks();
+        if (needsFlush) {
+            flushSession();
+        }
         reorderExtent.setEnabled(false);
-        setBatchingChunks(false);
+        if (chunkBatchingExtent != null) {
+            chunkBatchingExtent.setEnabled(false);
+        }
     }
 
     /**