new version of shellcheck; new problems

we bumped the version of shellcheck in the pcf-ops image so it complained about some new stuff

Signed-off-by: Panagiotis Xynos <panos@engineerbetter.com>

ci/tasks/lint.sh

@@ -23,4 +23,7 @@ gometalinter \
 --deadline=120s \
 ./...
 
-find . -name vendor -prune ! -type d -o -name '*.sh' -exec shellcheck {} +
+# Globally ignoring SC2154 as it doesn't play nice with variables
+# set by Concourse for use in tasks.
+# https://github.com/koalaman/shellcheck/wiki/SC2154
+find . -name vendor -prune ! -type d -o -name '*.sh' -exec shellcheck -e SC2154 {} +

ci/tasks/write-release-vars.sh

@@ -1,4 +1,8 @@
 #!/bin/bash
+# shellcheck disable=SC2091,SC2006
+
+# Disabling SC2091 above because we want to print commands encased in $()
+# Disabling SC2006 above because ``` code blocks are misinterpretted as shell execution
 
 set -eu