Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rperform Github Action Test #2

Merged
merged 73 commits into from Jul 8, 2022
Merged

Rperform Github Action Test #2

merged 73 commits into from Jul 8, 2022

Conversation

EngineerDanny
Copy link
Owner

@EngineerDanny EngineerDanny commented Jun 30, 2022

This is a simple PR to test Rperform custom Github actions.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

👋 Thanks for reporting!

@EngineerDanny
Copy link
Owner Author

EngineerDanny commented Jul 1, 2022

This is how I plan on implementing the auto-comments based on reading this similar issue and researching about the limitations of Github Actions.

  • With all tests which involve graph outputs, the images of the graphs will be uploaded as Github Artifacts. The bot will comment the test results as well as the link to the artifact.
  • The tests that only output datasets, like that of the Rperform::time_compare, the bot will comment only the test results.

@tdhock What are your suggestions on this ?

@EngineerDanny EngineerDanny self-assigned this Jul 1, 2022
Repository owner deleted a comment from github-actions bot Jul 6, 2022
@tdhock
Copy link
Collaborator

tdhock commented Jul 6, 2022

Hi this is a great start. Glad to see you got automatic comments on PRs working. However this tabular output is not so helpful, because it is difficult to see which tests may have become faster/slower. It is good to be able to see all the numbers in that table, but I imagine it would be more useful to let the user view a plot/graph and then download the table as CSV if interested.

@EngineerDanny
Copy link
Owner Author

@tdhock Thanks for the analysis. I will look into this and re-organise my outputs by using graphs/plots in place of tables.

@EngineerDanny EngineerDanny merged commit 0004275 into rperform_test Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants