Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

...string instead of []string for NewEntity #11

Closed
EtienneBruines opened this issue Apr 10, 2016 · 3 comments
Closed

...string instead of []string for NewEntity #11

EtienneBruines opened this issue Apr 10, 2016 · 3 comments

Comments

@EtienneBruines
Copy link
Member

Harley Laue noted at the slack-chat, that our ecs.NewEntity function takes a []string as an argument.

We could easily change this to ...string, without changing much to the ecs.NewEntity method, it wouldn't change anything to the Entity type, and it would make the syntax look way nicer.

e := ecs.NewEntity([]string{"RenderSystem", "MouseSystem"})

would become

e := ecs.NewEntity("RenderSystem", "MouseSystem")
@EtienneBruines
Copy link
Member Author

I could change this, and everything that depends on it (wiki, demos, tutorials) once I have an OK.

@paked
Copy link
Member

paked commented Apr 10, 2016

I've been thinking about this. Lets do it.

On Mon, Apr 11, 2016 at 9:24 AM Etienne Bruines notifications@github.com
wrote:

I could change this, and everything that depends on it (wiki, demos,
tutorials) once I have an OK.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#11 (comment)

@paked
Copy link
Member

paked commented Apr 11, 2016

Wooo! Progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants