Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Apple M1 #37

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Add support for Apple M1 #37

merged 2 commits into from
Feb 25, 2022

Conversation

otraore
Copy link
Member

@otraore otraore commented Feb 25, 2022

No description provided.

@otraore otraore added the bug label Feb 25, 2022
@otraore otraore self-assigned this Feb 25, 2022
Copy link
Member

@Noofbiz Noofbiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Is there any way to compress the old build tags to a single line when using the 'go:build()' tags, or does it have to be like that?

@otraore
Copy link
Member Author

otraore commented Feb 25, 2022

It's being automatically formatted by gofmt as part of the rollout to use the new build tags

@Noofbiz
Copy link
Member

Noofbiz commented Feb 25, 2022

Looks good to be me. Thanks for taking the time to do this and test it!

@Noofbiz Noofbiz merged commit d0e7659 into master Feb 25, 2022
@otraore otraore deleted the apple-m1 branch February 25, 2022 22:08
@otraore
Copy link
Member Author

otraore commented Feb 25, 2022

No problem, thanks for getting it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants