Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node 8 #4

Merged
merged 2 commits into from
Dec 15, 2017
Merged

Support Node 8 #4

merged 2 commits into from
Dec 15, 2017

Conversation

DanielGibbsNZ
Copy link
Contributor

I have a project that is dependant on this module, which prevents me from updating to Node 8.

@coveralls
Copy link

coveralls commented Nov 8, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 24485cc on DanielGibbsNZ:feature/support-node-8 into 18a7990 on EnoahNetzach:master.

package.json Outdated
@@ -2,7 +2,7 @@
"name": "extract-scss-variables",
"version": "0.2.1",
"engines": {
"node": "^4 || ^6 || ^7"
"node": "^4 || ^6 || ^7 || ^8"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say at this point to just support >=4 

@DanielGibbsNZ
Copy link
Contributor Author

Updated.

@coveralls
Copy link

coveralls commented Dec 13, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling d2c32f7 on DanielGibbsNZ:feature/support-node-8 into 18a7990 on EnoahNetzach:master.

@EnoahNetzach EnoahNetzach reopened this Dec 15, 2017
@EnoahNetzach EnoahNetzach merged commit 55132da into EnoahNetzach:master Dec 15, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d2c32f7 on DanielGibbsNZ:feature/support-node-8 into 18a7990 on EnoahNetzach:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d2c32f7 on DanielGibbsNZ:feature/support-node-8 into 18a7990 on EnoahNetzach:master.

@DanielGibbsNZ DanielGibbsNZ deleted the feature/support-node-8 branch December 16, 2017 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants