Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Message in Bulk #92

Closed
wants to merge 13 commits into from

Conversation

SinfulPhantom
Copy link

Summary

Adds logic to utilize Revolt's bulk message call for #91
https://developers.revolt.chat/api#tag/Messaging/operation/message_bulk_delete_req

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, …)

@SinfulPhantom
Copy link
Author

@EnokiUN - This is my first time contributing to this project. I have created a solution, but I'm not exactly sure how I can test this locally. Any advice would be much appreciated.
Thanks in advance!

@SinfulPhantom
Copy link
Author

SinfulPhantom commented Jul 5, 2023

I'm Squidwarden#6125 in Revolt if you need to reach me for anything

@EnokiUN
Copy link
Owner

EnokiUN commented Jul 6, 2023

@EnokiUN - This is my first time contributing to this project. I have created a solution, but I'm not exactly sure how I can test this locally. Any advice would be much appreciated.
Thanks in advance!

You can try creating a test.py in the root of your clone, it should be ignored bt the .gitignore and importing voltage there should use your own code

voltage/internals/http.py Outdated Show resolved Hide resolved
voltage/messageable.py Show resolved Hide resolved
@SinfulPhantom SinfulPhantom marked this pull request as ready for review July 10, 2023 05:26
@EnokiUN
Copy link
Owner

EnokiUN commented Jul 18, 2023

LGTM, just test it out and it'll be ready for merging. I sadly cannot currently test it myself since I'm abroad on vacation

@EnokiUN
Copy link
Owner

EnokiUN commented Nov 18, 2023

Any updates on this?

@SinfulPhantom
Copy link
Author

This is something I put in the back burner and never got around to. Will try to get it tested soon I hope. Holidays are coming up, so I'll need to find time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants