Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable status check #532

Merged
merged 6 commits into from Dec 19, 2023
Merged

Option to disable status check #532

merged 6 commits into from Dec 19, 2023

Conversation

TurnrDev
Copy link
Contributor

@TurnrDev TurnrDev commented Nov 21, 2023 •
edited by EnricoMi

Adds an option to disable checks. Fixes #491.

@TurnrDev TurnrDev mentioned this pull request Dec 12, 2023
Closed
@EnricoMi EnricoMi changed the title Add flag to unit test publisher to prevent check runs being published Option to disable status check Dec 18, 2023
@EnricoMi
Copy link
Owner

Thanks for this feature, I have fixed and extended the tests. I think the publish logic should also look different.

Please inspect my changes.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2023 •
edited

Test Results (reference)

   135 files  ±  0     135 suites  ±0   42m 19s ⏱️ - 1m 41s
   436 tests +  4     436 ✅ +  4      0 💤 ±0  0 ❌ ±0 
58 860 runs  +540  57 516 ✅ +540  1 344 💤 ±0  0 ❌ ±0 

Results for commit 4623574. ± Comparison against base commit 8cdbc41.

♻️ This comment has been updated with latest results.

EnricoMi
EnricoMi approved these changes Dec 18, 2023
View reviewed changes
Copy link
Owner

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TurnrDev
Copy link
Contributor Author

Thanks for this feature, I have fixed and extended the tests. I think the publish logic should also look different.

Please inspect my changes.

Thank you, I will take a look at some point this week.

TurnrDev
TurnrDev commented Dec 19, 2023
View reviewed changes
Copy link
Contributor Author

@TurnrDev TurnrDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EnricoMi EnricoMi merged commit d764099 into EnricoMi:master Dec 19, 2023
53 checks passed
@TurnrDev TurnrDev deleted the optional_check_run branch December 19, 2023 14:37
@TurnrDev
Copy link
Contributor Author

I tried to use this today pinned to the latest commit and it didn't work as expected. I assume this is due the container not being built. Is there an ETA on when we can expect the next build? :)

@EnricoMi
Copy link
Owner

You can try this directly from master via:

uses: EnricoMi/publish-unit-test-result-action/composite@master

The /composite is doing the magic here.

@ahernandez411 ahernandez411 mentioned this pull request Dec 22, 2023
Merged
kfr2 pushed a commit to turnitin-actions/publish-unit-test-result-action that referenced this pull request Feb 13, 2024
@TurnrDev @EnricoMi @kfr2
Add option to disable status check (EnricoMi#532)
54bf02a 
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EnricoMi EnricoMi EnricoMi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How do I disable checks? i.e. just get red/green step/job/workflow based on unit test results
2 participants
@TurnrDev @EnricoMi