Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer token #82

Merged
merged 4 commits into from Feb 6, 2021
Merged

Infer token #82

merged 4 commits into from Feb 6, 2021

Conversation

justAnotherDev
Copy link
Contributor

Use the GitHub provided ${{ github.token }} as the default so the user does not need to provide one.

Example of actions/checkout using the same syntax.

This update does NOT require existing users to change anything.

Note:
This PR also updates the CI file to use whatever the current fork/branch's code is instead of always using master. This allows other branches and forks to test before creating a PR.

@github-actions

This comment has been minimized.

Copy link
Owner

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent fixes, just one small remark.

@@ -134,7 +133,6 @@ and removal, and `skipped tests` to detect new skipped and un-skipped tests, as
See this complete list of configuration options for reference:
```yaml
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lists all available options, and in some cases you might want to provide a different token than the default one. So this should stay for completeness.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, good eye! i updated the name to your-custom-pat to try and emphasize that it isn't necessary to provide. happy to switch back to ${{ secrets.GITHUB_TOKEN }} or whatever other string you want.

05c3256

@@ -38,11 +38,10 @@ jobs:
python -m pytest --continue-on-collection-errors --junit-xml ../test-results/pytest.xml

- name: Unit Test Results
uses: EnricoMi/publish-unit-test-result-action@master
uses: ./
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this to work across branches and forks is great, this might even fix #45.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, likely will 😃

@github-actions

This comment has been minimized.

Copy link
Owner

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@EnricoMi
Copy link
Owner

EnricoMi commented Feb 6, 2021

@justAnotherDev can you delete the .github/.DS_Store file?

@justAnotherDev
Copy link
Contributor Author

@justAnotherDev can you delete the .github/.DS_Store file?

oops, done! 67b0d32

@github-actions

This comment has been minimized.

@EnricoMi EnricoMi merged commit 2d28b77 into EnricoMi:master Feb 6, 2021
@github-actions
Copy link

github-actions bot commented Feb 6, 2021

Unit Test Results

    1 files  ±0      1 suites  ±0   1s ⏱️ -1s
173 tests +2  173 ✔️ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 2d28b77. ± Comparison against base commit 56099e8.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
test_publish.PublishTest ‑ test_get_test_list_summary_md
test_publish.PublishTest ‑ test_get_long_summary_md_with_test_lists_and_zero_limit
test_publish.PublishTest ‑ test_get_test_changes_list_md
test_publish.PublishTest ‑ test_get_test_changes_md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants