"error: no such subcommand: +nightly-2022-09-07" when using rustdoc-json on windows

[jnises]

It seems I'm running into this bug rust-lang/rustup#3036
Nested cargo invocations have issues in recent versions of rustup on windows.

I'm trying to run code like:

rustdoc_json::build(BuildOptions::default().toolchain("+nightly"))

I'm on Windows 11

I can work around the issue by making cargo_rustdoc_command call rustup run nightly-2022-09-07 cargo ... instead of cargo +nightly-2022-09-07 ...

What is the correct way to run nested a cargo with a different toolchain?

[Enselic]

Thanks for reporting!

@Emilgardis Do you see any problem with us using rustup run ... instead?

@jnises Any chance you can create a PR with what works for you? If all our existing regression tests pass after the change, I am comfortable to use the change, because we have a good set of regression tests.

Assuming @Emilgardis does not know of any issues with switching to that. But I do believe that is also what cargo-expand is using, probably for good reason.

[Emilgardis]

switching to rustup run <toolchain> cargo ... when an override is mentioned sounds good, that's what +toolchain is supposed to be semantically equivalent to

Basically

cargo-public-api/rustdoc-json/src/build.rs

Lines 50 to 56 in e400615

	let mut command = Command::new("cargo");
	if let Some(toolchain) = OVERRIDDEN_TOOLCHAIN.or(requested_toolchain.as_deref()) {
	command.arg(toolchain);
	}
	command.arg("rustdoc");

would become

    let mut command = if let Some(toolchain) = OVERRIDDEN_TOOLCHAIN.or(requested_toolchain.as_deref()) {
        Command::new("rustup").args(["run", toolchain, "cargo"])
    } else {
        Command::new("cargo")
    }

    command.arg("rustdoc");    

[jnises]

#147 seems to do the same thing as my workaround.
So that should fix my issue :)

[Enselic]

Closed by #147