Use the tracing crate for debug logging and e.g. RUST_LOG=debug to activate
#564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enselic
added
the
category-exclude
Emilgardis
requested changes
Mar 29, 2024
cargo-public-api/src/main.rs
Outdated
| @@ -290,6 +290,7 @@ pub enum Action { | |||
| const LATEST_VERSION_ARG: &str = "latest"; | |||
|
|
|||
| fn main_() -> Result<()> { | |||
| tracing_subscriber::fmt::init(); | |||
There was a problem hiding this comment.
I think the default is to log to stdout, see https://togithub.com/tokio-rs/tracing/issues/2492
should be changed to stderr via the builder
There was a problem hiding this comment.
Thanks, good catch. I have now added a regression test that would have caught this mistake (and will catch similar mistakes in the future).
I don't think anyone is using `verbose()`, so going through a deprecation cycle would be overkill. Let's just remove it but release a new 0.x.0 version just to be safe.
Emilgardis
approved these changes
Apr 2, 2024
Enselic
added
category-other
Enselic
temporarily deployed
to
preview-release-notes
GitHub Actions
Inactive
Enselic
had a problem deploying
to
preview-release-notes
GitHub Actions
Failure
Enselic
changed the title
rustdoc_json::Builder::verbose with the tracing cratetracing crate for debug logging and e.g. RUST_LOG=debug to activate
Enselic
temporarily deployed
to
preview-release-notes
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From previous discussions my impression is that ideally we would use the
tracingcrate for logging.While investigating #561 I got a good reason to improve debug logging, so I switched to
tracing. It does add a handful of more deps, but I think it's worth it. Great logging capabilities are very nice to have.Obviously we can add more logging later, but this is a start.
I don't think anyone is using
verbose, so going through a deprecation cycle would be overkill. Let's just remove it but release a new 0.x.0 version just to be safe.