This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Changes to the buffer class #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakim-hove
force-pushed
the
ERT-932-empty-define
branch
from
202905e
to
23331ca
Compare
joakim-hove
force-pushed
the
ERT-932-empty-define
branch
from
23331ca
to
98da091
Compare
Have made the following changes to the buffer class: - Have tried to deprecate that buffer_fread_string() and buffer_fwrite_string() methods; these methods embed an integer string length in the buffer which gets funny. - The buffer_strstr() and buffer_strchr() methods are more robust towards binary \0 in the buffer. - The buffer_fwrite_char_ptr() function will append a trailing \0. - Have added a buffer_strcat() function.
joakim-hove
force-pushed
the
ERT-932-empty-define
branch
from
98da091
to
4b215d2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer.c file has essentially not been touched since 2009 - scary shit.