fix extra eip creation logic

[ravisinghkr]

📲 What

Fix to avoid creation of 3 EIPs (per AZ for NAT) if we are creating just 1 NAT Gateway.

🤔 Why

We dont want to create unnecessary resources in our environments.

🛠 How

Adding a check while creating the aws_eip resource.

👀 Evidence

🕵️ How to test

Notes on how a reviewer can test the changes, e.g. how to run the tests.

✅ Acceptance criteria Checklist

• Code peer reviewed?
• Documentation has been updated to reflect the changes?
• Passing all automated tests, including a successful deployment?
• Passing any exploratory testing?
• Rebased/merged with latest changes from development and re-tested?
• Meeting the Coding Standards?

[ElvenSpellmaker]

Hey, aren't all the IPs used even in the single mode?

[ravisinghkr]

Hey, aren't all the IPs used even in the single mode?

not really, 2 are just created and never used. Only one of them is used by the NAT gateway

resource "aws_nat_gateway" "public" {
  count = var.vpc_nat_gateway_per_az ? length(data.aws_availability_zones.available.names) : 1

  allocation_id = aws_eip.nat[count.index].id
  subnet_id     = aws_subnet.public[count.index].id

  tags = merge(var.tags, {
    "Name" = "${var.vpc_name}-public-nat-${data.aws_availability_zones.available.names[count.index]}"
  })

[ElvenSpellmaker]

Hey, aren't all the IPs used even in the single mode?

not really, 2 are just created and never used. Only one of them is used by the NAT gateway

resource "aws_nat_gateway" "public" {
  count = var.vpc_nat_gateway_per_az ? length(data.aws_availability_zones.available.names) : 1

  allocation_id = aws_eip.nat[count.index].id
  subnet_id     = aws_subnet.public[count.index].id

  tags = merge(var.tags, {
    "Name" = "${var.vpc_name}-public-nat-${data.aws_availability_zones.available.names[count.index]}"
  })

Fair enough, in that case LGTM.