Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Update acls security groups #120

Merged
merged 21 commits into from
Jun 13, 2024
Merged

Conversation

ravisinghkr
Copy link
Contributor

📲 What

A description of the change.

🤔 Why

Why it's needed, background context.

🛠 How

More in-depth discussion of the change or implementation.

👀 Evidence

Screenshots / external resources / links / etc.
Link to documentation updated with changes impacted in the PR.

🕵️ How to test

Notes on how a reviewer can test the changes, e.g. how to run the tests.

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

balpurewal and others added 21 commits February 9, 2024 15:02
Allows us to add additional policies to the node group iam role if needed
This way it behaves the same and nodes aren't recreated.
Will not merge this branch into master and only used temporarily.
Co-authored-by: Dibya Dhar <dibay.dhar@ensono.com>
@ravisinghkr ravisinghkr merged commit 0b29776 into master Jun 13, 2024
2 checks passed
@ravisinghkr ravisinghkr deleted the update-acls-security-groups branch June 13, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants