Exposing node security groups and ACLs #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows us to add additional policies to the node group iam role if needed
This way it behaves the same and nodes aren't recreated. Will not merge this branch into master and only used temporarily.
Co-authored-by: Dibya Dhar <dibay.dhar@ensono.com>
…nto payuk-cis-bootstrap
…nto update-acls-security-groups
…nto update-acls-security-groups
…nto update-acls-security-groups
ravisinghkr
requested review from
ElvenSpellmaker,
balpurewal and
dibyadhar
and removed request for
ElvenSpellmaker and
balpurewal
balpurewal
approved these changes
Jun 13, 2024
ElvenSpellmaker
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Exposing default node security groups via variables
Creating and exposing network ACLs via variables to have our own ACLs
🤔 Why
So that we can get rid of the default node security rules and have our own and can use our own ACLs instead of the default ones
🛠 How
Moved security rules and ACLs to variables which can be set while using the module.