Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagram ids #11

Closed
DaelDe opened this issue Aug 20, 2019 · 4 comments
Closed

diagram ids #11

DaelDe opened this issue Aug 20, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@DaelDe
Copy link

DaelDe commented Aug 20, 2019

Is your feature request related to a problem? Please describe.
Plantuml allows to assign an ID to a diagram for the purpose of reuse.

@startuml(id=MY_OWN_ID)
@enduml

See: http://plantuml.com/de/preprocessing

Describe the solution you'd like
Either the ID is parsed or everything after @startuml is ignored.

@DaelDe DaelDe added the enhancement New feature or request label Aug 20, 2019
@DaelDe
Copy link
Author

DaelDe commented Aug 20, 2019

I would actually prefer that additional content after @startuml is ignored.

My use case is that diagrams are included in doxygen. In this context the command can have parameters.

Enteee added a commit that referenced this issue Aug 20, 2019
@Enteee
Copy link
Owner

Enteee commented Aug 20, 2019

good catch, there is very little documentation around this id feature.

Also the online plantuml parser just strips that Infomation. So I would assume this id should just contain all non white space ascii characters. What is still unclear to me is if id also supports quoting and what the expected bahaviour should be if there are whitespaces in the id

@startuml(id=what is the id now?)
Bob -> Alice : hello
@enduml

@Enteee
Copy link
Owner

Enteee commented Aug 20, 2019

just noticed that a missing closing parenthesis does not yield an error in plantuml

@startuml(id=missing
@enduml

this is something I don't what to support.

@Enteee
Copy link
Owner

Enteee commented Aug 20, 2019

I think using the Name terminal here is what we want.

Name
  = name:([A-Za-z0-9._]+)
  {
    return name.join('');
  }

Enteee added a commit that referenced this issue Aug 21, 2019
* Add fixture from issue-#11
* implement diagramId parsing
* rename fixture
@Enteee Enteee closed this as completed Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants