Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update Activity Overview for MMIS #4415

Closed
4 tasks
thetif opened this issue Nov 22, 2022 · 0 comments · Fixed by #4445
Closed
4 tasks

[Feature] Update Activity Overview for MMIS #4415

thetif opened this issue Nov 22, 2022 · 0 comments · Fixed by #4445
Assignees
Labels
Development Issues for the dev team resolve

Comments

@thetif
Copy link
Contributor

thetif commented Nov 22, 2022

Description and related issues

MMIS Activities don't have different funding types, so the funding type needs to be removed. Schedule has already been moved as part of #4371. The rich text fields are also different.

Shared fields

  • Activity Name

Fields for MMIS only

  • Activity Snapshot
  • Problem Statement
  • Proposed Solution

Remove the Program type field.

Fields for HITECH only

  • Program type
  • Summary
  • Description
  • Alternatives
  • Standards and Conditions

Behind the scenes changes:

  • add new set methods for the new MMIS fields actions/editActivity/overview.js.

Schema format for this section:

...
activities: [{
  ...
  activityOverview: {
    activitySnapshot: 'String',
    problemStatement: 'String', 
    proposedSolution: 'String'
  },
  ...
}]
...

Mockups or link to Figma

https://www.figma.com/file/hJpKHKU6fz5J0Z7fisSwa2/eAPD-MMIS-2022?node-id=1388:12346&t=gKKGaYKaKXLCJ9Tk-0

Acceptance criteria

Given When Then

This task is done when…

  • all acceptance criteria are met
  • the Activity Overview component has been updated to handle HITECH and MMIS APD activities
  • the new MMIS values are saving in mongo
  • the new MMIS values are being displayed when the APD is opened again
@thetif thetif added the Development Issues for the dev team resolve label Nov 22, 2022
@amyd11 amyd11 self-assigned this Dec 7, 2022
amyd11 added a commit that referenced this issue Jan 18, 2023
* WIP activities overview for MMIS

* create overview wrapper component

* scope StandardsAndConditions to HITECH type

* use Controller component for MMIS fields

* split NameAndFundingSourceForm into two components

* remove unused NameAndFundingSourceReview component and associated directory

* udpate ActivityRoutes snapshot test since StandardsAndConditions was moved into the Overview component

* resolving test warnings, add test

* cleanup, add tests

* cypress testing

* move test location after rebase

* test update after display text change

* capitalization changes for display text

* adding comment for extra clarity

* removing useMemos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development Issues for the dev team resolve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants