Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend user sessions on API activity #1734

Merged
merged 2 commits into from
Aug 21, 2019
Merged

Conversation

mgwalker
Copy link
Contributor

@mgwalker mgwalker commented Jul 26, 2019

This pull request changes...

This pull request is ready to merge when...

  • Tests have been updated (and all tests are passing)
  • This code has been reviewed by someone other than the original author
  • Changelog is updated as appropriate

This feature is done when...

  • Product has approved the experience
    This one is tricky to test because a backend session is valid for 48 hours at a time. I guess if you log in on Monday, then open the site on Tuesday and Wednesday, if you're still logged in on Thursday, it worked!

@cms-eapd-bot
Copy link

cms-eapd-bot commented Jul 26, 2019

This deploy was cleaned up.

@jeromeleecms
Copy link
Contributor

Logged in on 07/30. Will try to login on 07/31 and 08/01. Will try and report back on 08/02.

@jeromeleecms
Copy link
Contributor

@mgwalker Logged in on 07/30 - returned on 08/01 to site, but was logged out of the system. That seems to be the expected behavior based on our time out settings. I'm not sure how to verify that's the right behavior that I'm actually extending the API backend?

Copy link
Contributor

@hbillings hbillings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay stretch armstrong

@mgwalker
Copy link
Contributor Author

mgwalker commented Aug 1, 2019

@jeromeleecms The way to test it is to login and note the time. Then in less than 48 hours, open it up - that should extend your session. Finally, just over 48 hours after you initially logged in (but less than 48 hours after you visited the second time!), open it again. If you're still logged in, it worked! If you're not... then it didn't... :sadface:

@hbillings
Copy link
Contributor

What do we need to do to close this one?

@mgwalker
Copy link
Contributor Author

@hbillings I think we couldn't test it because of #1756. I'm pretty confident this does what it's supposed to, but we can't be sure yet. I'm content to merge it now and double-check when #1756 goes in, though. What do you think, @jeromeleecms?

Copy link
Contributor

@jeromeleecms jeromeleecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, no great way to test this, but doesn't break the app!

@mgwalker mgwalker merged commit 28fb7f3 into master Aug 21, 2019
@mgwalker mgwalker deleted the mgwalker/1728-extend-sessions branch August 21, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend sessions are never extended
4 participants