Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the auth session cookie to expire at the same time the session will expire #1776

Merged
merged 3 commits into from
Sep 9, 2019

Conversation

mgwalker
Copy link
Contributor

@mgwalker mgwalker commented Aug 22, 2019

This pull request changes...

This pull request is ready to merge when...

  • Tests have been updated (and all tests are passing)
  • This code has been reviewed by someone other than the original author
  • Changelog is updated as appropriate

@cms-eapd-bot
Copy link

cms-eapd-bot commented Aug 22, 2019

This deploy was cleaned up.

@codecov-io
Copy link

codecov-io commented Aug 22, 2019

Codecov Report

Merging #1776 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1776      +/-   ##
==========================================
+ Coverage   93.18%   93.19%   +<.01%     
==========================================
  Files         196      196              
  Lines        4258     4259       +1     
  Branches      559      559              
==========================================
+ Hits         3968     3969       +1     
  Misses        275      275              
  Partials       15       15
Impacted Files Coverage Δ
api/auth/session.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9174202...1058f9a. Read the comment docs.

@mgwalker mgwalker merged commit 6fac9f2 into master Sep 9, 2019
@mgwalker mgwalker deleted the mgwalker/1756-auth-cookie-expiration branch September 9, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth token cookie does not have an expiration
4 participants