Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tbolt/4416 mmis proposed budget #4517

Merged
merged 89 commits into from Feb 25, 2023
Merged

Tbolt/4416 mmis proposed budget #4517

merged 89 commits into from Feb 25, 2023

Conversation

tbolt
Copy link
Contributor

@tbolt tbolt commented Feb 3, 2023

Resolves #4416

Description

  • Updates the budget calculation in the backend to compute key state personnel for MMIS apds
  • Adds new selector for calculating the key state personnel totals to support new table in Proposed Budget for MMIS apds
  • Adds new component to display new key state personnel table for MMIS apds
  • Updates to Proposed Budget page language for MMIS apds
  • Updates Proposed Budget page to match Figma design

Significant changes or possible side effects

  • HITECH apds should work as it did prior to these code changes. It's possible the MMIS changes could have impacted HITECH apds

Steps to manually verify this change

  1. Login as a user who can view APDs
  2. Open a HITECH apd
  3. Verify that Proposed Budget page for HITECH is working as intended. All tables are still present, totals, subtotals, cost categories, export view, etc...
  4. Navigate to or create a MMIS apd
  5. Verify that Proposed Budget page now loads
  6. Verify that all acceptance criteria in the original ticket is working
  7. Verify the Proposed Budget page matches the Figma file (with the exception of the newly added Medicaid Share % that was discussed in standup)

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • New automated test cases are documented above
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

…l seeds, fix issue preventing medicaidShare from saving to the backend, update snapshots
@thetif
Copy link
Contributor

thetif commented Feb 15, 2023

Looks great, could you please change the instances of 'MMIS' to use APD_TYPE.MMIS and 'HITECH' to use APD_TYPE.HITECH?

@mirano-darren mirano-darren self-assigned this Feb 16, 2023
@mirano-darren
Copy link
Contributor

Looks good! Couple of small things:
This should be total instead of subtotal
image

Empty state for State and Contractor costs:
image

@mirano-darren
Copy link
Contributor

Looks good to me pending the changes above!

Given When Then Result
Proposed Budget page on an MMIS APD Implementation matches Figma Design
Proposed Budget page on an MMIS APD, adding Key Personnel KP is added to all relevant tables
Proposed Budget page on an MMIS APD, changing the fed state split of a Key Personnel Summary Budget tables reflect the change
Proposed Budget page on an MMIS APD, deleting Key Personnel All tables should be updated to reflect the delete
Proposed Budget page on an MMIS APD, changing Key Personnel cost All tables should be updated to reflect the change in cost
Proposed Budget page on an MMIS APD, KP with costs then Deleting an FFY All tables should be updated to reflect the change if FFYs
Proposed Budget page on an MMIS APD, KP with long name Name is formatted correctly

Copy link
Contributor

@mirano-darren mirano-darren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 2 small issues were fixed!

Copy link

@SGilliamA1M SGilliamA1M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks great! One small request for indentation of State and Contractor Cost Breakdown table (see screenshot below)
image

Copy link
Contributor

@jeromeleecms jeromeleecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew! As far as I can tell, the budgets for HITECH and MMIS work as advertised. Made some minor adjustments to the Wiki page as well. Nice work!

@tbolt tbolt merged commit 49fe6e6 into main Feb 25, 2023
@tbolt tbolt deleted the tbolt/4416-mmis-proposed-budget branch February 25, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature PR label for release log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Update Proposed Budget for MMIS
8 participants