Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NZ/4514 - APD name should be required in the new APD form #4534

Merged
merged 6 commits into from Feb 13, 2023

Conversation

Sun-Mountain
Copy link
Contributor

@Sun-Mountain Sun-Mountain commented Feb 9, 2023

Resolves #4514

Description

The new APD form should require the APD name have a value

Automated test cases written

Given When Then Type (jest, tap, cypress)
a user is creating an APD the name field hasn't been touched the Create new APD button should be disabled jest
a user is creating an APD the name field is empty and has been touched the error message displays below the field and the Create new APD button should be disabled jest
a user is creating an APD the name field is filled out and the rest of the form is valid the Create new APD button is enabled jest

Steps to manually verify this change

  1. Go to create a new APD
  2. Select APD name field and go off, ensure error message shows
  3. You can only create an APD if a name is supplied

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • New automated test cases are documented above
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #4534 (a542544) into main (2e76d0a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4534   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files         253      253           
  Lines        7885     7885           
  Branches     1686     1686           
=======================================
  Hits         7438     7438           
  Misses        428      428           
  Partials       19       19           
Impacted Files Coverage Δ
web/src/pages/apd/new/ApdNew.js 99.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e76d0a...a542544. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Feb 9, 2023

See this pull request in action: https://ec2-18-206-77-240.compute-1.amazonaws.com

a542544

@Sun-Mountain Sun-Mountain marked this pull request as ready for review February 9, 2023 19:49
@mirano-darren mirano-darren self-assigned this Feb 13, 2023
Copy link
Contributor

@mirano-darren mirano-darren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Well done 😄

Copy link
Contributor

@jeromeleecms jeromeleecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised!

Copy link

@SGilliamA1M SGilliamA1M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great!

@Sun-Mountain Sun-Mountain merged commit 6905221 into main Feb 13, 2023
@Sun-Mountain Sun-Mountain deleted the nz/4514-apd-name-required branch February 13, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] APD name should be required in the new APD form
7 participants