Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tbolt/4602 Update help text on cost allocation and other funding page for MMIS #4619

Merged
merged 9 commits into from Mar 22, 2023

Conversation

tbolt
Copy link
Contributor

@tbolt tbolt commented Mar 17, 2023

Resolves #4602

Description

Text updates on MMIS page for cost allocation and other funding

Chromatic Link

N/A

Significant changes or possible side effects

None

Automated test cases written

No new test cases written. Existing tests updated to work with text changes.

Steps to manually verify this change

  1. Login and view HITECH APD and verify existing help text not impacted (covered by existing test)
  2. Login and view MMIS APD and verify help text is according to specification

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • New automated test cases are documented above
  • Chromatic link added above
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #4619 (c0ffa21) into main (7b781d2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4619   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files         273      273           
  Lines        8694     8694           
  Branches     1746     1746           
=======================================
  Hits         8201     8201           
  Misses        469      469           
  Partials       24       24           
Flag Coverage Δ
api ∅ <ø> (∅)
common 100.00% <ø> (ø)
web 94.07% <ø> (ø)
Impacted Files Coverage Δ
...ies/cost-allocation/CostAllocation/OtherFunding.js 93.47% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b781d2...c0ffa21. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Mar 17, 2023

See this pull request in action: https://ec2-18-233-210-18.compute-1.amazonaws.com

c0ffa21

@tbolt tbolt added the content Some design issues are more specifically content issues label Mar 20, 2023
Copy link
Contributor

@Sun-Mountain Sun-Mountain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@thetif thetif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mirano-darren
Copy link
Contributor

Looks good to me! Let Ty know about one small typo I found.
image

Given When Then Result
A HITECH APD on the Cost Allocation and Other Funding page Help text should not be updated
A MMIS APD on the Cost Allocation and Other Funding page Help text should be updated

@mirano-darren mirano-darren self-requested a review March 21, 2023 13:21
@tbolt
Copy link
Contributor Author

tbolt commented Mar 21, 2023

@mirano-darren Resolved

Copy link
Contributor

@jeromeleecms jeromeleecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

@SGilliamA1M SGilliamA1M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great!

@tbolt tbolt merged commit 72fba6d into main Mar 22, 2023
9 checks passed
@tbolt tbolt deleted the tbolt/4602-help-text-cost-allocation-other-funding branch March 22, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Some design issues are more specifically content issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Update help text on Cost Allocation and Other Funding
8 participants